Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flutter_tools] add vm service method to pull SkSL #57813

Merged
merged 3 commits into from
May 27, 2020
Merged

[flutter_tools] add vm service method to pull SkSL #57813

merged 3 commits into from
May 27, 2020

Conversation

jonahwilliams
Copy link
Member

@jonahwilliams jonahwilliams commented May 22, 2020 •
edited

Description

Add a method to pull a SkSL file via the vm service so that an integration test does not have to use stdin/stdout.

@fluttergithubbot fluttergithubbot added tool Affects the "flutter" command-line tool. See also t: labels. work in progress; do not review labels May 22, 2020
@jonahwilliams jonahwilliams marked this pull request as ready for review May 26, 2020 15:02
@jmagman jmagman merged commit 6003382 into flutter:master May 27, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zanderso zanderso zanderso approved these changes

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jonahwilliams @zanderso @jmagman @googlebot @fluttergithubbot